Add locale requirements to linux build script#3934
Add locale requirements to linux build script#3934ksomml wants to merge 1 commit intoopensim-org:mainfrom ksomml:main
Conversation
Fixes issue #3924
|
I don't think this is the best long-term solution. This PR just masks the locale problem; anyone who installs a pre-built linux artifact on a system with a comma decimal locale will still encounter this issue because the locale change here is system specific/dependent and isn't fixing the root cause. |
|
That is true, mainly wanted to get attention to this issue, as it essentially makes you unable to load motions onto the model in the GUI. I do not know how to fix the issue at its root cause. |
|
There are a few problems with this change:
|
|
Then I believe this pull request can be closed? Though the issue #3924 will still remain. I might take a look to see if i could fix it, but I believe someone more experienced is more likely to find the root cause of this. I already closed the PR for the opensim-gui now, because the root cause lies in opensim-core. |
|
Agreed that build scripts shouldn't make global changes to either Locale or Path in order to avoid unintended side-effects, so closing the PR but thanks for bringing the issue to the forefront @ksomml and for the feedback @alexbeattie42 and @halleysfifthinc |
Fixes issue #3924
Brief summary of changes
Added locale changes into the build script so numeric formatting is correct when using TimeSeriesTable.h
Testing I've completed
Tested locally with a separate shell script. A restart after locale changes is recommended if locale changes have been applied due to different settings instead of directly using OpenSim after installation.
Looking for feedback on...
/
CHANGELOG.md (choose one)
This change is